Should FileStorage.do_store create the outputpath directory ?

[huard]

Description

I'm a bit confused on whether or not PyWPS is expected to create the outputpath directory if it does not exist.

The documentation says server path where to store output files.

If the directory does not exist, PyPWS fails in this call here
but it feels like this failure could be avoided by computing the free space on the drive where the target resides, or the closest existing parent directory. Later in the code, os.makedirs is called, suggesting an intent to create recursively the target path.

So it's not clear to me exactly what the desired behavior is.

Environment

• operating system: Ubuntu
• Python version: 3.9
• PyWPS version: 4.4

[tlvu]

Other than server.outputpath, there are 2 other directories in the wps.cfg config file: server.workdir and server.temp_path that will also need the dir to be created on service startup, if the dir do not already exist.

[cehbrecht]

In my deployments the Ansible playbook is creating the temp folders with correct permissions. So, the error was avoided.

Would it help to run this code before get_free_space(self.target)?:

if not os.path.exists(self.target):
            os.makedirs(self.target)

[huard]

@cehbrecht Yes, I think so. I was just not sure if recursive directory creation was meant to be supported. If so, I can submit a PR for it.