Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unversionned package-lock.json file #95

Closed
severo opened this issue Nov 17, 2018 · 3 comments
Closed

Unversionned package-lock.json file #95

severo opened this issue Nov 17, 2018 · 3 comments

Comments

@severo
Copy link

severo commented Nov 17, 2018

When compiling geonetwork inside of https://github.com/georchestra/georchestra, following: https://github.com/georchestra/georchestra/blob/18.06/docs/build.md#build-the-modules, and then launch

git status

we get

HEAD detached at efaded366
Untracked files:
  (use "git add <file>..." to include in what will be committed)

        package-lock.json

nothing added to commit but untracked files present (use "git add" to track)

We should do one of the following:

  • add this file to .gitignore
  • version this file

I understand that the good practice is to version it, as stated in the official npm documentation: https://docs.npmjs.com/files/package-lock.json

@severo
Copy link
Author

severo commented Nov 17, 2018

Note that I don't fully understand how we manage the various georchestra submodules and their branches, so I don't want to propose a PR for the moment.

@severo
Copy link
Author

severo commented Nov 27, 2018

See #97

@fvanderbiest
Copy link
Member

+1 on versioning it, as we already do for https://github.com/georchestra/georchestra/tree/18.06/console/src/main/webapp/manager

I don't fully understand how we manage the various georchestra submodules and their branches, so I don't want to propose a PR for the moment.

georchestra master uses geonetwork-3.4-master
georchestra 18.06 uses geonetwork-3.4-18.06

We also "cascade merge" fixes from geonetwork-3.4-18.06 into geonetwork-3.4-master & update submodules accordingly ... I know this is complex but we did not find a better way !

@fvanderbiest fvanderbiest changed the title Version package-lock.json Unversionned package-lock.json file Jan 3, 2019
cmangeat pushed a commit that referenced this issue Sep 9, 2019
validation: process xlink after UFO cause keyword are lost and schema…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants