Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support appending sec-* headers as configured, resolved from authenticated user #12

Merged

Conversation

groldan
Copy link
Member

@groldan groldan commented Apr 8, 2022

  • Generate test covearge report with jacoco-maven-plugin
    Adds @Generated annotation to lombok's @Data classes
    for jacoco to exclude them from the report.

    Implement missing user sec- headers, and JSON header contributor for user and org

  • Relocate sources and build georchestra dependencies
    fall back to Java 11. Georchestra modules won't build
    with Java 17. Revisit and possibly fix upstream.

  • Add georchestra as a shallow-clone submodule
    Use georchestra-ldap-account-management dependency to get full LDAP user/org info

  • Support appending sec-* headers as configured, resolved from authenticated user

Copy link
Member

@pmauduit pmauduit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some early comments from my current understanding

@groldan groldan force-pushed the feature/append_georchestra_security_headers branch 5 times, most recently from fae09e7 to a4b6679 Compare April 12, 2022 13:50
@groldan groldan force-pushed the feature/append_georchestra_security_headers branch 8 times, most recently from 5254cf6 to e8b3f28 Compare April 14, 2022 14:57
- fall back to Java 11. Georchestra modules won't build
with Java 17. Revisit and possibly fix upstream.
@groldan groldan force-pushed the feature/append_georchestra_security_headers branch 3 times, most recently from 2812195 to 671f07b Compare April 18, 2022 22:52
@groldan groldan force-pushed the feature/append_georchestra_security_headers branch from 671f07b to 9cf8e55 Compare April 18, 2022 23:42
@groldan groldan marked this pull request as ready for review April 18, 2022 23:50
Adds `@Generated` annotation to lombok's `@Data` classes
for jacoco to exclude them from the report.
@groldan groldan merged commit 218dbcc into georchestra:main Apr 19, 2022
@groldan groldan deleted the feature/append_georchestra_security_headers branch April 19, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants