-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support appending sec-* headers as configured, resolved from authenticated user #12
Merged
groldan
merged 6 commits into
georchestra:main
from
groldan:feature/append_georchestra_security_headers
Apr 19, 2022
Merged
Support appending sec-* headers as configured, resolved from authenticated user #12
groldan
merged 6 commits into
georchestra:main
from
groldan:feature/append_georchestra_security_headers
Apr 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmauduit
reviewed
Apr 11, 2022
src/main/java/org/georchestra/gateway/autoconfigure/app/HeaderFiltersAutoConfiguration.java
Show resolved
Hide resolved
pmauduit
reviewed
Apr 11, 2022
pmauduit
reviewed
Apr 11, 2022
src/main/java/org/georchestra/gateway/filter/global/ResolveTargetGlobalFilter.java
Outdated
Show resolved
Hide resolved
pmauduit
reviewed
Apr 11, 2022
src/main/java/org/georchestra/gateway/filter/headers/HeaderProvider.java
Outdated
Show resolved
Hide resolved
pmauduit
reviewed
Apr 11, 2022
src/main/java/org/georchestra/gateway/filter/headers/providers/UserSecurityHeadersProvider.java
Outdated
Show resolved
Hide resolved
pmauduit
reviewed
Apr 11, 2022
src/main/java/org/georchestra/gateway/model/GeorchestraUser.java
Outdated
Show resolved
Hide resolved
pmauduit
reviewed
Apr 11, 2022
src/main/java/org/georchestra/gateway/model/GeorchestraUser.java
Outdated
Show resolved
Hide resolved
pmauduit
reviewed
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some early comments from my current understanding
fae09e7
to
a4b6679
Compare
5254cf6
to
e8b3f28
Compare
- fall back to Java 11. Georchestra modules won't build with Java 17. Revisit and possibly fix upstream.
2812195
to
671f07b
Compare
671f07b
to
9cf8e55
Compare
Adds `@Generated` annotation to lombok's `@Data` classes for jacoco to exclude them from the report.
pmauduit
reviewed
Apr 22, 2022
gateway/src/main/java/org/georchestra/gateway/security/ldap/LdapSecurityConfiguration.java
Show resolved
Hide resolved
...java/org/georchestra/gateway/filter/headers/providers/JsonPayloadHeadersContributorTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate test covearge report with jacoco-maven-plugin
Adds
@Generated
annotation to lombok's@Data
classesfor jacoco to exclude them from the report.
Implement missing user sec- headers, and JSON header contributor for user and org
Relocate sources and build georchestra dependencies
fall back to Java 11. Georchestra modules won't build
with Java 17. Revisit and possibly fix upstream.
Add georchestra as a shallow-clone submodule
Use georchestra-ldap-account-management dependency to get full LDAP user/org info
Support appending sec-* headers as configured, resolved from authenticated user