Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype applying georchestra access rules #4

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

pmauduit
Copy link
Member

@pmauduit pmauduit commented Mar 9, 2022

Note the patterns changed from Pattern to String
to use Ant patterns instead of Java regex.

Rule uri's should be updated accordingly.

@pmauduit
Copy link
Member Author

pmauduit commented Mar 9, 2022

a NPE is fired in the tests because we can't have anonymous: false with no roles defined:
https://github.com/georchestra/georchestra-gateway/blob/main/src/main/resources/gateway.yml#L17-L18

Easily fixed by adding a allowed-roles: ... on the /testPage endpoint. Il will also require to switch from regex-based to ant-like patterns, we will have to remove '.' to simple wildcards ''.

Note the patterns changed from Pattern to String
to use Ant patterns instead of Java regex.

Rule uri's should be updated accordingly.
@groldan groldan marked this pull request as ready for review March 28, 2022 23:19
@groldan groldan merged commit a80b69c into main Mar 28, 2022
@groldan groldan deleted the apply_access_rules branch March 28, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants