Refactor LDAP account creation functionality for better separation of concerns #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… concerns
* Account creation self contained at the `org.georchestra.gateway.accounts.*`
packages. Use an application event to decouple account creation from
OAuth2 configurations and beans.
* Decouple RabbitMQ events from OAuth2 and Accounts creation
functionality. Introduce `RabbitmqAccountCreatedEventSender` as an
application level event listener for account creation events, and
bridge them to the RabbitMQ queue.
* Define rabbitmq config properties under georchestra.gateway.security.events.rabbitmq.*
Use spring-boot friendly configuration properties to enable and
configure rabbitmq event dispatching, defaulting to root level
properties usually coming from geOrchestra's `default.properties` to be
shared with the console application.
```
georchestra:
gateway:
security:
events:
rabbitmq:
# Note usually enableRabbitmqEvents, rabbitmqHost, etc. come from georchestra's default.properties
enabled: ${enableRabbitmqEvents:false}
host: ${rabbitmqHost}
port: ${rabbitmqPort}
user: ${rabbitmqUser}
password: ${rabbitmqPassword}
```
Co-authored-by: marwanehcine <marwane.benhcine@camptocamp.com>
Co-authored-by: Pierre Mauduit <pierre.mauduit@camptocamp.com>
Co-authored-by: Emmanuel Durin <emmanuel.durin@camptocamp.com>
|
Note this is all the refactoring work performed as part of #63 that's not strictly related to the new feature of supporting request headers pre-authentication itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account creation self contained at the
org.georchestra.gateway.accounts.*packages. Use an application event to decouple account creation from OAuth2 configurations and beans.Decouple RabbitMQ events from OAuth2 and Accounts creation functionality. Introduce
RabbitmqAccountCreatedEventSenderas an application level event listener for account creation events, and bridge them to the RabbitMQ queue.Define rabbitmq config properties under georchestra.gateway.security.events.rabbitmq.*
Use spring-boot friendly configuration properties to enable and configure rabbitmq event dispatching, defaulting to root level properties usually coming from geOrchestra's
default.propertiesto be shared with the console application.