Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push to docker hub github actions per commit #74

Merged

Conversation

edevosc2c
Copy link
Member

@edevosc2c edevosc2c commented Nov 7, 2023

Allow to retain older versions of the master branch of georchestra gateway.

Each new commit will be available under the docker image georchestra/gateway:commit-the_sha_id

We are currently in a fast moving period of the software, and sometimes it breaks the infrastructure. It would be great to be able to easily and rapidly come back to a previous commit of gateway instead of spending the time in building a new docker image locally.

Only downside is that docker hub doesn't really allow setting ourselves an automatic expiration of the docker images. Only quay.io does allow it.
However, it seems like docker hub does it own automatic expiration so we should still be good with that: https://www.docker.com/blog/docker-hub-image-retention-policy-delayed-and-subscription-updates/

allow to retain older versions of the master branch of georchestra gateway
@groldan
Copy link
Member

groldan commented Nov 7, 2023

On the bright side, using spring-boot-maven-plugin to build the images means there will be a lot of shared layers across images. unless dependencies change, only the layer with the application classes should change between one and the other

Copy link
Member

@groldan groldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not totally fond on the approach but we can start with that and revisit if/when needed. Maybe we should use github's container registry for these snapshot images.

@edevosc2c
Copy link
Member Author

Maybe we should use github's container registry for these snapshot images.

That's what I thought but if we do it this way then it's for private usage because it would be "half" hidden from the public.

Whereas if it's in the same repo, the public can benefit from it.

Not sure on what's the best approach here.

@groldan
Copy link
Member

groldan commented Nov 8, 2023

as mentioned, feel free to merge since if you need it you need it. We can tackle the inconvenience later

@edevosc2c edevosc2c merged commit 74ddb3c into georchestra:main Nov 8, 2023
3 checks passed
@edevosc2c edevosc2c deleted the github-actions-commitid-docker-image branch November 8, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants