Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addons init improvement #1006

Closed
fvanderbiest opened this issue Jul 10, 2015 · 3 comments
Closed

addons init improvement #1006

fvanderbiest opened this issue Jul 10, 2015 · 3 comments
Assignees
@fvanderbiest
Labels
3 - Done enhancement
Milestone
15.12

Comments

@fvanderbiest
Copy link
Member

In https://github.com/georchestra/georchestra/blob/15.06/mapfishapp/src/main/webapp/app/js/GEOR_tools.js#L303 it would be better to pass the GeoExt.MapPanel instance rather than the OpenLayers.Map instance.
@fvanderbiest fvanderbiest self-assigned this Jul 10, 2015
@fvanderbiest fvanderbiest added this to the 15.12 milestone Jul 10, 2015
@fvanderbiest fvanderbiest removed their assignment Jul 12, 2015
@fvanderbiest fvanderbiest mentioned this issue Oct 16, 2015
Merged
@fvanderbiest fvanderbiest self-assigned this Oct 16, 2015
@fvanderbiest
Copy link
Member Author

There aren't many things to change since addons inherit from a base class.
#1092

Migration should be easy...

@landryb
Copy link
Member

landryb commented Oct 19, 2015

Yes please, this will be quite useful for addons that want to interact deeply with other ext components..

@fvanderbiest
Copy link
Member Author

Done, I'm sure it will be useful to many existing and future addons !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fvanderbiest fvanderbiest

Labels
3 - Done enhancement
Projects
None yet
Milestone
15.12
Development

No branches or pull requests
2 participants
@fvanderbiest @landryb