Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to ogc-server-statistics to pass all tests #2392

Merged
merged 3 commits into from Jan 22, 2019
Merged

Fixes to ogc-server-statistics to pass all tests #2392

merged 3 commits into from Jan 22, 2019

Commits on Jan 19, 2019

  1. Fix wrong column name secrole -> roles in RetrieveAllCommand

    @groldan
    groldan committed Jan 19, 2019
    Copy the full SHA
    29f478e View commit details
    Browse the repository at this point in the history

  2. Extract out stats table and column names and other fixes 

    - Move repeated hardcoded values for statistics table
and column names to a constants in a LogColumns utility.

- Use try-with-resources when dealing with JDBC
prepared statements and resultsets.

- Do now swallow exception cause when throwing
DataCommandException
    @groldan
    groldan committed Jan 19, 2019
    Copy the full SHA
    c6887c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. Fix all tests failures when running with -PAllTests 

    Most failed because OGCServiceParser couldn't parse the
OGC service name, especially out of the HTTP POST requests
log messages. Fixed using regular expressions.

The only test passing was OGCServiceParserTest, but lacked
test cases for the failing messages, which were added.
    @groldan
    groldan committed Jan 21, 2019
    Copy the full SHA
    6227a61 View commit details
    Browse the repository at this point in the history