Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analytics - extractorapp: replace the Ext.js git submodule by a webjar #2446

Merged
merged 1 commit into from
May 17, 2019

Conversation

groldan
Copy link
Member

@groldan groldan commented Feb 1, 2019

Webjars (https://www.webjars.org/) are client side JS
libraries packaged into a .jar file.

According to the documentation for servlet 3 apps
(https://www.webjars.org/documentation#servlet3) we just need
to add the required dependency.

This patch replaces the Ext.js git submodule by the extjs
4.1.1a jar dependency in both extractorapp and analytics,
saving ~500M of disk space in the developer's source code
checkout.

@pmauduit
Copy link
Member

pmauduit commented Feb 1, 2019

I'm not a ExtJS / Frontend expert, but I'm pretty sure we sometime use a fork of Extjs or whatever JS lib. this sounds promising though, is there a way to have a maven module when we need customizations of these libs ? (which would generate a georchestra-extjs-whatver-webjar.jar)

@groldan
Copy link
Member Author

groldan commented Feb 1, 2019

yes, generating a webjar is really simple and can be done with a maven project that saves static resources under META-INF/resources/webjars/<library name>/<version>.
As for using them, there's an locator dependency that can be added to resolve the installed version so you don't need to set it in the import paths (e.g. src="extjs/ext.js would automatically resolve to extjs/<installed version>/ext.js.

@fvanderbiest
Copy link
Member

Sounds very interesting Gabriel !
Please update the branch, there are conflicting files.

@fvanderbiest fvanderbiest added this to the 19.06 milestone Feb 12, 2019
Webjars (https://www.webjars.org/) are client side JS
libraries packaged into a .jar file.

According to the documentation for servlet 3 apps
(https://www.webjars.org/documentation#servlet3) we just need
to add the required dependency.

This patch replaces the Ext.js git submodule by the extjs
4.1.1a jar dependency in both extractorapp and analytics,
saving ~500M of disk space in the developer's source code
checkout.
@fvanderbiest fvanderbiest merged commit c375493 into georchestra:master May 17, 2019
@fvanderbiest fvanderbiest added this to In progress in Geo2France via automation May 17, 2019
@groldan groldan deleted the remove_extjs_submodule branch August 23, 2019 15:56
@fvanderbiest fvanderbiest modified the milestones: 19.09, 19.12 Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Geo2France
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants