[console] unbreak account creation form after 8df191a (fixes #2522) #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR should have targeted 18.12 ? |
|
Yes |
|
Note to myself: the file already contains a lot of placeholders... First understand the difference with the Spring placeholders before reviewing. |
OK they come from the model used in the form and defined in the https://github.com/georchestra/georchestra/blob/18.12/console/src/main/java/org/georchestra/console/ws/newaccount/NewAccountFormController.java class. I hope mixing placeholders from different sources will not end conflicts (general comment, not related directly to this PR) |
severo
approved these changes
Feb 21, 2019
|
Backported to 18.12 with cbc4889. Note: I should have cherry-picked first in 18.12, PR, and then merged into master... Never mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing readonlyUid spring placeholder
please test it at runtime and merge to 18.12 :)