changing make file to reflect git branch on building #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this maven option will also work with fixed version (ex: 19.04, 19.06 etc..)
fvanderbiest
requested changes
May 17, 2019
|
Yess that was my intitial thought 😄 |
|
Did you try it ? since I cannot find any occurence of I'd have put a dockerImageTag property which by default would have taken project.version, if you want to keep the possibility to override it (anyway, it's still overrideable using -DdockerImageName and fully giving a custom image name + tag). |
|
Yup I tested it ;-) |
|
Ok, I was not aware of the possibility by the spotify docker maven plugin to override the tag this way, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this maven option will also work with fixed version (ex: 19.04,
19.06 etc..)