Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console - link to org page from user's page #2653

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

Gaetanbrl
Copy link
Contributor

Ask reviewers here (can't see reviewers panel) @landryb @pierrejego

@landryb
Copy link
Member

landryb commented Jul 22, 2019

Tested working fine, @fvanderbiest @tonio does this look ok to merge for you ?

@tonio
Copy link
Contributor

tonio commented Jul 22, 2019

I find a bit confusing to have the link inside the widget: what about a link to open in a new tab as for the password?
Screenshot from 2019-07-22 11-56-34

@landryb
Copy link
Member

landryb commented Jul 22, 2019

I find a bit confusing to have the link inside the widget: what about a link to open in a new tab as for the password?
Screenshot from 2019-07-22 11-56-34

cf #2618 (comment) - it was evaluated, but after feedback from our users admin it's more natural to be able to click on the name instead of having yet another cryptic pictogram.

@landryb
Copy link
Member

landryb commented Jul 22, 2019

About opening in new tabs, #2449 tracks this :)

@fvanderbiest
Copy link
Member

@Gaetanbrl can you assign a reviewer now ?

@Gaetanbrl Gaetanbrl assigned landryb and unassigned landryb Jul 22, 2019
@Gaetanbrl
Copy link
Contributor Author

Gaetanbrl commented Jul 22, 2019

Thank you @fvanderbiest. I could assign the PR but not the Reviewer.
Maybe it's too late if the PR already exist ?
image

@tonio
Copy link
Contributor

tonio commented Jul 22, 2019

Not completely convinced with the appearance, but if we go that way, please consider cherry-picking 98cff46, formatter has superfluous complexity.

@fvanderbiest
Copy link
Member

Not completely convinced with the appearance

Same here. Can someone provide me with a better, bigger screenshot ?

@fvanderbiest fvanderbiest changed the title Create link to access to org page from user's page directly georchest… console - link to org page from user's page Jul 22, 2019
@fvanderbiest
Copy link
Member

I could assign the PR but not the Reviewer.

OK, there's no easy way ... sigh

@landryb
Copy link
Member

landryb commented Jul 22, 2019

image

@fvanderbiest fvanderbiest requested a review from tonio July 26, 2019 08:11
@fvanderbiest fvanderbiest added this to the 19.06 milestone Jul 26, 2019
@fvanderbiest
Copy link
Member

Waiting @Gaetanbrl takes into account @tonio 's remark regarding code complexity.
Thanks

@Gaetanbrl
Copy link
Contributor Author

Cherry-pick takes into account @fvanderbiest

@fvanderbiest fvanderbiest merged commit 2859dbf into georchestra:master Sep 6, 2019
@fvanderbiest fvanderbiest added this to In progress in CRAIG via automation Sep 6, 2019
@landryb landryb moved this from In progress to Done in CRAIG Sep 10, 2019
@Gaetanbrl Gaetanbrl deleted the issue-2618-pr branch October 16, 2019 09:37
@fvanderbiest fvanderbiest modified the milestones: 19.09, 19.12 Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CRAIG
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants