-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support geojson in mapfishapp #2655
Merged
fvanderbiest
merged 5 commits into
master
from
gshdf-245-geojson-file-upload-in-mapfishapp
Jul 25, 2019
Merged
Support geojson in mapfishapp #2655
fvanderbiest
merged 5 commits into
master
from
gshdf-245-geojson-file-upload-in-mapfishapp
Jul 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should target Probably also misses a better comment in https://github.com/georchestra/georchestra/blob/master/postgresql/020-mapfishapp.sql#L8 @groldan to the rescue for the tests ? |
RemiDesgrange
force-pushed
the
gshdf-245-geojson-file-upload-in-mapfishapp
branch
from
July 24, 2019 11:11
e5ec27f
to
a9b5c91
Compare
groldan
changed the title
First attend to support geojson in mapfishapp
First attempt to support geojson in mapfishapp
Jul 24, 2019
groldan
force-pushed
the
gshdf-245-geojson-file-upload-in-mapfishapp
branch
2 times, most recently
from
July 25, 2019 10:09
4fcdc87
to
3c2a629
Compare
groldan
force-pushed
the
gshdf-245-geojson-file-upload-in-mapfishapp
branch
from
July 25, 2019 10:13
3c2a629
to
980f558
Compare
RemiDesgrange
changed the title
First attempt to support geojson in mapfishapp
Support geojson in mapfishapp
Jul 25, 2019
RemiDesgrange
commented
Jul 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot approve me own PR. But 👍 LGTM. Thanks @groldan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@groldan or @fvanderbiest If you look at the test mapfishapp/src/test/java/org/georchestra/mapfishapp/ws/upload/GeotoolsFeatureReaderTest.java#L450 and you launch the test, you'll see it fail. But it work for example with EPSG:2154. I have no Idea :-(