Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support geojson in mapfishapp #2655

Merged
merged 5 commits into from
Jul 25, 2019

Conversation

RemiDesgrange
Copy link
Contributor

@groldan or @fvanderbiest If you look at the test mapfishapp/src/test/java/org/georchestra/mapfishapp/ws/upload/GeotoolsFeatureReaderTest.java#L450 and you launch the test, you'll see it fail. But it work for example with EPSG:2154. I have no Idea :-(

@fvanderbiest
Copy link
Member

It should target master, it's a feature.

Probably also misses a better comment in https://github.com/georchestra/georchestra/blob/master/postgresql/020-mapfishapp.sql#L8

@groldan to the rescue for the tests ?

@RemiDesgrange RemiDesgrange changed the base branch from 19.04 to master July 24, 2019 11:07
@RemiDesgrange RemiDesgrange force-pushed the gshdf-245-geojson-file-upload-in-mapfishapp branch from e5ec27f to a9b5c91 Compare July 24, 2019 11:11
@groldan groldan changed the title First attend to support geojson in mapfishapp First attempt to support geojson in mapfishapp Jul 24, 2019
@groldan groldan force-pushed the gshdf-245-geojson-file-upload-in-mapfishapp branch 2 times, most recently from 4fcdc87 to 3c2a629 Compare July 25, 2019 10:09
@groldan groldan force-pushed the gshdf-245-geojson-file-upload-in-mapfishapp branch from 3c2a629 to 980f558 Compare July 25, 2019 10:13
@RemiDesgrange RemiDesgrange changed the title First attempt to support geojson in mapfishapp Support geojson in mapfishapp Jul 25, 2019
Copy link
Contributor Author

@RemiDesgrange RemiDesgrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot approve me own PR. But 👍 LGTM. Thanks @groldan

@fvanderbiest fvanderbiest merged commit 80ee661 into master Jul 25, 2019
@fvanderbiest fvanderbiest added this to the 19.06 milestone Jul 25, 2019
@fvanderbiest fvanderbiest added this to In progress in Geo2France via automation Jul 25, 2019
@fvanderbiest fvanderbiest deleted the gshdf-245-geojson-file-upload-in-mapfishapp branch July 25, 2019 12:13
@fvanderbiest fvanderbiest modified the milestones: 19.09, 19.12 Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Geo2France
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants