Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console - filter org/role members #2657

Merged
merged 3 commits into from
Sep 19, 2019
Merged

console - filter org/role members #2657

merged 3 commits into from
Sep 19, 2019

Conversation

Gaetanbrl
Copy link
Contributor

Link to #2469
Ask manual reviewers (no reviewers panel) @pierrejego @landryb

pierrejego
pierrejego approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@pierrejego pierrejego left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I am not the best to review this part :)

@landryb landryb requested a review from tonio July 25, 2019 06:05
@landryb
Copy link
Member

landryb commented Jul 25, 2019

tested, works fine. thanks!

@Gaetanbrl Gaetanbrl changed the title Add users filter on org/role members Filter org/role members Jul 25, 2019
@fvanderbiest fvanderbiest changed the title Filter org/role members console - filter org/role members Jul 26, 2019
@fvanderbiest fvanderbiest added this to the 19.06 milestone Jul 26, 2019
@fvanderbiest fvanderbiest self-requested a review August 23, 2019 07:40
fvanderbiest
fvanderbiest requested changes Aug 23, 2019
View reviewed changes
Copy link
Member

@fvanderbiest fvanderbiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the "Filter" widget is in the top right corner of page /console/manager/#!/browse/all/users, I would go for the same disposition here, moving the "User add" widget to the top left corner.

@RemiDesgrange
Copy link
Contributor

@Gaetanbrl can you rebase against master to see if test pass in travis. Test fail bc of too much line. This issue has been resolved.

@fvanderbiest
Copy link
Member

@Gaetanbrl can you rebase against master to see if test pass in travis. Test fail bc of too much line. This issue has been resolved.

This PR is client-side only ...

@Gaetanbrl
Copy link
Contributor Author

Gaetanbrl commented Sep 9, 2019 •
edited

Need last test and clean, since last commit in #2657 (include suspicious merge by automation).
=> force rebase and clean resolved suspicious merge

@fvanderbiest fvanderbiest merged commit 97eb9ba into georchestra:master Sep 19, 2019
@landryb landryb mentioned this pull request Sep 23, 2019
Closed
@Gaetanbrl Gaetanbrl deleted the issue-2469-pr branch September 30, 2019 12:50
@fvanderbiest fvanderbiest modified the milestones: 19.09, 19.12 Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvanderbiest fvanderbiest fvanderbiest requested changes

@pierrejego pierrejego pierrejego approved these changes

@tonio tonio Awaiting requested review from tonio

Assignees

@Gaetanbrl Gaetanbrl

Labels
feature
Projects
None yet
Milestone
20.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gaetanbrl @landryb @RemiDesgrange @fvanderbiest @pierrejego