console - do not show pending users/orgs on the all users/org page #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvanderbiest
changed the title
fvanderbiest
changed the title
|
LGTM but requires a rebase. Thanks. |
Indeed, it's now necessary. Thanks for review. |
RemiDesgrange
suggested changes
Sep 2, 2019
console/src/main/webapp/manager/app/components/orgs/orgs.tpl.html
Outdated
Show resolved
Hide resolved
Gaetanbrl
force-pushed
the
issue-2456-pr
branch
from
6adaaf7
to
5ddf644
Compare
|
Rebase and requests applied @fvanderbiest. Thanks for reviews and tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to #2456
Ask manual reviewers (no reviewers panel) @pierrejego @landryb