Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom - Adding jacoco as code coverage tool optionally #2665

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

pmauduit
Copy link
Member

@pmauduit pmauduit commented Jul 30, 2019

Some external code analysis tools used in the community (deutsch telekom
do have a SonarQube deployed in their infrastructure, we have a
community Jenkins) can make use of the generated report by Jacoco
to get insights on the code coverage of the solution.

This commit proposes to activate the maven plugin as an optional profile
which can (or not) be activated.

Tested in the security-proxy as:

$ mvn clean test -PjacocoCoverage

This generates a target/site/jacoco path.

Without:

$ mvn clean test

No code coverage report is generated, the behaviour is exactly the same
as currently in master.

Some external code analysis tools used in the community (deutsch telekom
do have a SonarQube deployed in their infrastructure, we have a
communautary Jenkins) can make use of the generated report by Jacoco
to get insights on the code coverage of the solution.

This commit proposes to activate the maven plugin as an optional profile
which can (or not) be activated.

Tested in the security-proxy as:

```
$ mvn clean test -PjacocoCoverage
```

This generates a target/site/jacoco path.

Without:

```
$ mvn clean test
```

No code coverage report is generated, the behaviour is exactly the same
as currently in master.
@pmauduit pmauduit requested a review from groldan July 30, 2019 08:41
@pmauduit pmauduit changed the title pom - Adding jacoco as code coverage tool optionnally pom - Adding jacoco as code coverage tool optionally Jul 30, 2019
@fvanderbiest fvanderbiest added this to the 19.06 milestone Aug 13, 2019
@fvanderbiest fvanderbiest merged commit b3a0421 into master Aug 23, 2019
@fvanderbiest fvanderbiest deleted the jacocoIntegration branch August 23, 2019 07:44
@fvanderbiest fvanderbiest modified the milestones: 19.09, 19.12 Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants