Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct backend to serve csv and vcf. #2670

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Conversation

RemiDesgrange
Copy link
Contributor

Only VCF work ATM.

Also correct ldapScheme.

@groldan @cmangeat Can you try CSV export and tell me what piece I'm missing here ?

I also wasn't able to make the JSON parsing via spring. According to "the internet" having :

public String getUsersAsCsv(@RequestParam List<String> rawUsers) 

Should be possible but I cannot make it working.

@fvanderbiest fvanderbiest added this to the 19.06 milestone Aug 1, 2019
@fvanderbiest fvanderbiest added this to In progress in Geo2France via automation Aug 1, 2019
@cmangeat
Copy link
Contributor

cmangeat commented Aug 2, 2019

For csv, seems there are no need for converters, just changing produce into:
produces = "text/comma-separated-values;charset=utf-8".

(I think that when url ends with ".csv", a resolution is attempted and lead to this).

@cmangeat cmangeat merged commit ea2e387 into master Aug 7, 2019
Geo2France automation moved this from In progress to Done Aug 7, 2019
@RemiDesgrange RemiDesgrange deleted the gshdf-28-contact-exports branch August 20, 2019 08:57
@fvanderbiest fvanderbiest modified the milestones: 19.09, 19.12 Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Geo2France
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants