Org referents #2697
Merged
Org referents #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiDesgrange
force-pushed
the
org-referents
branch
2 times, most recently
from
61e0bff
to
2a82c83
Compare
groldan
requested changes
Aug 28, 2019
There was a problem hiding this comment.
Hi Remi, I've rebased on top of master for you since it was my fault to commit the code formatting with the wrong formatter.xml file.
Please do:
git remote add groldan git@github.com:groldan/georchestra.git
git fetch groldan
git reset --hard groldan/org-referents
Before continuing with the requested changes, which btw are rather minimal, PR looks good overal.
console/src/main/java/org/georchestra/console/ws/editorgdetails/EditOrgDetailsFormBean.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/org/georchestra/console/ws/editorgdetails/EditOrgDetailsFormController.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/georchestra/console/ws/edituserdetails/EditUserDetailsFormController.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/org/georchestra/console/ws/editorgdetails/EditOrgDetailsFormController.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/georchestra/console/ws/editorgdetails/EditOrgDetailsFormControllerTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/georchestra/console/ws/editorgdetails/EditOrgDetailsFormControllerTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/georchestra/console/ws/editorgdetails/EditOrgDetailsFormControllerTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/georchestra/console/ws/editorgdetails/EditOrgDetailsFormControllerTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
August 29, 2019 14:27
RemiDesgrange
force-pushed
the
org-referents
branch
from
932fc20
to
d0b0bd1
Compare
groldan
approved these changes
Aug 31, 2019
fvanderbiest
approved these changes
Sep 2, 2019
| @@ -29,6 +29,13 @@ editUserDetailsForm.organisation=Organization | |||
| editUserDetailsForm.url=Website | |||
| editUserDetailsForm.areaOfCompetence=Area of competence | |||
| editUserDetailsForm.members=Members | |||
| editUserDetailsForm.editOrg=Edit Organization | |||
There was a problem hiding this comment.
The PR should also update the other translation files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability for a user with the role
REFERENTto edit some of the field of his organization.REFERENTrole is now a protected role in georchestra. This PR contain the frontend and the bacend implementation.