Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console - fixing serialization of cities in Org #2708

Merged
merged 1 commit into from
Sep 16, 2019
Merged

console - fixing serialization of cities in Org #2708

merged 1 commit into from
Sep 16, 2019

Conversation

pmauduit
Copy link
Member

This PR aims to fix the JSON format returned for the organizations:

Hitting <georchestra>/console/private/orgs/<myorg>

returns (in case of multivalued cities) a JSON entry as follows:

 "cities":["62270,62178"]

Where the UI actually expects:

 "cities":["62270","62178"]

Tests:

  • Added utests to test the Org Attribute Mapper
  • mvn test OK
  • mvn verify OK

@pmauduit pmauduit merged commit f65ee8f into master Sep 16, 2019
@pmauduit pmauduit deleted the fix-org-cities-serialization branch September 16, 2019 15:55
@fvanderbiest
Copy link
Member

fvanderbiest commented Sep 17, 2019 •
edited

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmangeat cmangeat cmangeat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmauduit @fvanderbiest @cmangeat