Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP - reorganize files for docker image #2715

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Conversation

fvanderbiest
Copy link
Member

This change allows to only COPY docker-root / in the dockerfile.
The drawback (which is not really one) is that symlincks have to be used to not duplicate LDIF files.

This also emphasizes the fact that we had two memberof.ldif files (see #2544), one of which was unused.

Regarding the inclusion of ldap-utils & procps:

@landryb
Copy link
Member

landryb commented Nov 19, 2019

Fwiw this part of the PR for 3/4 files seems weird: 213a085#diff-0baf0f56c9b48799dd931323cd72377c

an ldif file containing a path to another ldif file ? that's sure to confuse users.... or was it supposed to be a symlink ?

@fvanderbiest
Copy link
Member Author

fvanderbiest commented Nov 19, 2019

Right, it's a symlink, that github does not handle as I would have expected

@landryb
Copy link
Member

landryb commented Nov 20, 2019

ah well, "interesting". Then people downloading files from the github web UI are confused :)

@fvanderbiest
Copy link
Member Author

I tried hard to find the best solution avoiding duplication and complexity, but it seems like there is no silver bullet here

@landryb
Copy link
Member

landryb commented Dec 6, 2019

Fwiw, as a side effect, i just realized this completely broke the ansible playbook deployments, so far beyond repair. The 19.04 branch is also broken by e3e4dc0 but maybe i can fix this one 'easily'..

i'm considering just marking the ansible repo as abandoned, since changes in georchestra are done without (apparently) testing anything outside docker deployment... there's more and more deviation/discrepancy between the 'follow the traditional docs' and "i dont give a f*** i just run docker-compose-yolo". Yes, i'm saddened by this sorry state :)

landryb added a commit to georchestra/ansible that referenced this pull request Dec 6, 2019
- add missing georchestraSchema & openssh schemas
- adapt paths to point inside docker-root subdirs
- use basename filter to shorten temp ldif names and keep changes minimal
@fvanderbiest
Copy link
Member Author

Thanks Landry for the head-up.
As you can imagine, we do not break things on purpose, it's just a matter of available time.
Before each release I try to check / fix / help with the ansible deployment on my professional time.

But you're right, there's an open question about who's maintaining it & with which resources & for what purpose ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants