Console - enhance email template by adding orgs to new users #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo
RemiDesgrange
force-pushed
the
gshdf-228-fix-email-template
branch
from
7501e34
to
36a4203
Compare
RemiDesgrange
changed the title
fvanderbiest
changed the title
fvanderbiest
requested changes
Sep 27, 2019
| @@ -150,6 +150,9 @@ public void sendNewAccountNotificationEmail(ServletContext servletContext, List< | |||
| email.set("name", userName); | |||
| email.set("uid", uid); | |||
| email.set("email", userEmail); | |||
| if (userOrg == null) { | |||
| userOrg = "None"; | |||
There was a problem hiding this comment.
I'd rather have an empty string here, since there is no email template i18n
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add org of the user when new user register (see also datadir). Having Org in your template is nor mandatory. If it's present it will be populated accordingly