console: null-proof GDPR record parsing and encoding #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure no null value comming from the database can break the GDPR data export. Use commons-cvs to write csv file to ensure the contents of the files are correctly formatted.
fvanderbiest
requested review from
pmauduit and
RemiDesgrange
and removed request for
fvanderbiest
pmauduit
reviewed
Nov 14, 2019
console/src/main/java/org/georchestra/console/ws/backoffice/users/GDPRAccountWorker.java
Show resolved
Hide resolved
pmauduit
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
I have not a good knowledge of this code, but the diff looks good to me.
Use commons-csv to write csv file to ensure the contents
of the files are correctly formatted.
Since no modification have been made onto the pom, I supposed it has already been introduced earlier. Relying on the current state of the pom it does (and since no version are specified, I'd guess it comes from the root pom or spring-boot-dependencies). It seems better using the lib than generating it by hand indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure no null value coming from the database can
break the GDPR data export.
Use commons-csv to write csv file to ensure the contents
of the files are correctly formatted.