console - fix unable to filter stats based on user roles #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… role where group was taken into account
cmangeat
changed the title
cmangeat
changed the title
| @@ -792,8 +794,12 @@ private String convertUTCDateToLocal(String rawDate, GRANULARITY granularity) th | |||
| private String getGroup(JSONObject payload) throws JSONException { | |||
| if (payload.has("group")) | |||
There was a problem hiding this comment.
It seems strange to keep this test IMO
fvanderbiest
changed the title
…ining filter, remove indirection
fvanderbiest
changed the title
fvanderbiest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter on role where role and group were ignored, filter on group xor role where group was taken into account