Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analytics - rename groups into orgs / roles (depending on context) #2832

Merged
merged 4 commits into from
Jan 24, 2020
Merged

analytics - rename groups into orgs / roles (depending on context) #2832

merged 4 commits into from
Jan 24, 2020

Conversation

fvanderbiest
Copy link
Member

No description provided.

@fvanderbiest fvanderbiest self-assigned this Nov 27, 2019
@fvanderbiest fvanderbiest added this to the 19.12 milestone Nov 27, 2019
@fvanderbiest fvanderbiest marked this pull request as ready for review January 20, 2020 16:42
@fvanderbiest fvanderbiest changed the title analytics - rename groups into orgs analytics - rename groups into orgs / roles (depending on context) Jan 20, 2020
@fvanderbiest
Copy link
Member Author

@cmangeat @RemiDesgrange The build fails due to formatting issues

[ERROR] Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.10.0:validate (default) on project analytics: File '/home/travis/build/georchestra/georchestra/analytics/src/main/java/org/georchestra/analytics/StatisticsController.java' has not been previously formatted.  Please format file and commit before running validation! -> [Help 1]

How can I fix it ?

@RemiDesgrange
Copy link
Contributor

@fvanderbiest I've run mvn formatter:validate, and mvn formatter:format. It should be now.

@fvanderbiest fvanderbiest merged commit f8428f8 into master Jan 24, 2020
@fvanderbiest fvanderbiest deleted the analytics-rename-group-org branch January 24, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmauduit pmauduit Awaiting requested review from pmauduit

@cmangeat cmangeat Awaiting requested review from cmangeat

@RemiDesgrange RemiDesgrange Awaiting requested review from RemiDesgrange

Assignees

@RemiDesgrange RemiDesgrange

Labels
bikeshedding
Projects
None yet
Milestone
20.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fvanderbiest @RemiDesgrange