docker - unzip webapps in the container #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #2644 and others for the motivation / inspiration. tests: runtime tested a generated image * unzipped OK * docker run seems OK (webapp loaded, waiting for postgres to come alive)
Tests: * docker run bash: webapp unzipped in webapps/ * docker run: waiting for the db to become ready
Tests: * docker run bash: webapp unzipped in webapps/ OK * docker run: webapp init (but fails because datadir missing) OK
tests: same as on the other ones
To be reworked after #2848 is fixed, as i am not sure we have to work with the actual webapp, maybe the target/geowebcache directory does not contain every needed resources.
Tests: same as previously on the other ones
Tests: same as previously
fvanderbiest
approved these changes
Dec 3, 2019
|
Shall we consider merging, knowing the fact that it won't address #2848 ? |
As discussed, we can consider merging (once the checks are OK). |
|
Pending travis build is actually green, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the customization (via volumes or so) easier.
inspired from what as already been done on CAS & SP, like the following PR:
https://github.com/georchestra/georchestra/pull/2644/files
Note: I encountered an issue while working on this, which might be worth waiting for a fix:
#2848
Tests:
Each module tested with
mvn clean package docker:build, then manually checking that:/var/lib/jetty/webapps