Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian10 compatibility #2852

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Debian10 compatibility #2852

merged 3 commits into from
Dec 11, 2019

Conversation

fvanderbiest
Copy link
Member

@fvanderbiest fvanderbiest added this to the 19.12 milestone Dec 11, 2019
landryb
landryb approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@landryb landryb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although i still have shivers down my spine when i see old-school init scripts in the doc.. even if systemd can be a nightmare, at that point i think we have to swallow the pill and cross the bridge, instead of keeping init scripts for which compatibility is slowly fading away....

but anyway, given that the systemd unit we have in ansible right now seems broken because of the missing pidfile, it's wise to keep our init script for now :)

@fvanderbiest fvanderbiest merged commit f233591 into master Dec 11, 2019
@fvanderbiest fvanderbiest deleted the debian10 branch December 11, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landryb landryb landryb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fvanderbiest @landryb