Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Enable history api #2864

Merged
merged 1 commit into from
Jan 3, 2020
Merged

[Console] Enable history api #2864

merged 1 commit into from
Jan 3, 2020

Conversation

tonio
Copy link
Contributor

@tonio tonio commented Jan 2, 2020

To switch from url like /console/manager/#!orgs/all to /console/manager/orgs/all.
No need for server tweaks, previous redirection should work as expected.

Related to #2449

@tonio
Copy link
Contributor Author

tonio commented Jan 2, 2020

Travis fails because of security-proxy tests, looks unrelated to me.

@fvanderbiest fvanderbiest added this to the 19.12 milestone Jan 2, 2020
@fvanderbiest fvanderbiest added this to In progress in Geo2France via automation Jan 2, 2020
@fvanderbiest
Copy link
Member

@fvanderbiest
Copy link
Member

Note to self : check the apache doc requires an update (regarding redirections) https://github.com/georchestra/georchestra/blob/master/docs/setup/apache.md#configuration currently advises:

RewriteCond %{REQUEST_URI} !^/console/manager/public/.*$
RewriteCond %{REQUEST_URI} ^/console/manager/([home|users|org|orgs|role|roles|logs|analytics|delegations].*)$
RewriteRule .* /console/manager/#/%1 [NE,R,L]

@fvanderbiest fvanderbiest merged commit 2fea05c into master Jan 3, 2020
Geo2France automation moved this from In progress to Done Jan 3, 2020
@fvanderbiest fvanderbiest deleted the enable_history_api branch January 3, 2020 08:44
@fvanderbiest
Copy link
Member

check the apache doc requires an update (regarding redirections)

I think these redirections should be performed at the console webapp level (eg using UrlRewriteFilter), not on the frontend LB.
Something like https://gist.github.com/Serg-de-Adelantado/c1d76d4c316fee44d9ea rather than

acl console_routes path_reg \/console\/manager\/[browse|delegations|home|users|org|orgs|role|roles|logs|analytics]
http-request redirect code 301 location "https://%[hdr(host)]%[url,regsub(^/console/manager/,/console/manager/#!/,g)]" if console_routes

This will allow URLs like /console/manager/roles/all to be correctly displayed after CAS login (they currently are not, due to the non routability of /console/manager/#!/roles/all, see #1085 ).

@fvanderbiest
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Geo2France
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants