Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console - fix service publishing mandatory fields for orgs #2868

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

RemiDesgrange
Copy link
Contributor

Now web service that return the mandatory fields for orgs
(/public/requiredFields) depends on the Validation object. Which can be
overrided by properties.

Now web service that return the mandatory fields for orgs
(/public/requiredFields) depends on the Validation object. Which can be
overrided by properties.
Copy link
Member

@landryb landryb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant test it at runtime right now but that seems to make sense - @Gaetanbrl can you check it fixes #2666 for you ?

@Gaetanbrl
Copy link
Contributor

Cant test it at runtime right now but that seems to make sense - @Gaetanbrl can you check it fixes #2666 for you ?

I could check it now.

@Gaetanbrl
Copy link
Contributor

Gaetanbrl commented Jan 6, 2020

LGTM with this tests:

Values from console.properties :

requiredFields= firstName,surname,org
  • orgType mandatory -> OK.
    Could not validate form without orgType.
    requiredFields=firstName,surname,org, orgType

Values from console.properties :

requiredFields= firstName,surname,org,orgType

@Gaetanbrl
Copy link
Contributor

Gaetanbrl commented Jan 6, 2020

@RemiDesgrange could you just change the name / title of this PR ? Thanks.

@fvanderbiest fvanderbiest added this to the 19.12 milestone Jan 7, 2020
@fvanderbiest fvanderbiest changed the title Resolve issue #2666. console - fix service publishing mandatory fields for orgs Jan 7, 2020
@fvanderbiest fvanderbiest merged commit 3aefe4f into master Jan 7, 2020
@fvanderbiest fvanderbiest deleted the issue-2666-mandatory-business-category branch January 7, 2020 09:31
@fvanderbiest fvanderbiest added this to In progress in Geo2France via automation Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Geo2France
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants