Github actions - Activating extra profiles #2987
Conversation
There is nothing actually secret into it, the forks which also run the gh actions could also benefit from this configuration.
1. fork won't likely to have the necessary secrets to push 2. docker images are built with tests disabled, if nothing is done (e.g saving the images somewhere), then they will lost at the end of the build and we are just wasting computing resources. There is no added value of building them after the initial build.
Note: This will add optional dependencies to the generated docker images. The overhead is ~ 750 KB, so even if these dependencies are not used at runtime, we consider that the size increase is acceptable, compared to the artifact actual size. For the record: * log4j-logstash adds the jsonevent-layout log4j1 dependency, which allows to have a "jsonified" output, which is interesting in case of parsing the logs with tools like logstash. * sentry-spring will add the following ones: ``` [INFO] \- io.sentry:sentry-spring:jar:1.7.27:compile [INFO] \- io.sentry:sentry:jar:1.7.27:compile ``` And allows the webapp to be connected against a sentry instance. See https://docs.sentry.io/clients/java/integrations/#spring for the configuration details.
pmauduit
force-pushed
the
activating-extra-profiles
branch
from
9347a49
to
05a1ffd
Compare
|
👍 for me |
|
Probably a lighter syntax can be achieved with https://github.com/marketplace/actions/cancel-this-build |
I think we still want the test / verify goals actions from maven being run in the forks. My strategy had been to basically "skip the step whenever it needs a secret". I'm curious to know what the suggested action does exactly (which state will get the job in case of cancellation ?) |
It's using the github actions API to cancel the job, so the job will get a |
|
Please also consider porting to https://github.com/georchestra/geonetwork/blob/georchestra-gn3.8.2-master/.github/workflows/geonetwork-docker.yml |
|
Should be backported to 20.0.x branch too |
I cannot see the point of even activating the github-actions for forks on the georchestra/geonetwork repository: the tests are skipped. |
|
Also, there are no |
This PR actually aims to improve some of the github actions workflows:
M2_SETTINGS_FILEsecret: there is actually nothing secret about it (see actions - remove the need for a M2_SETTINGS_FILE secret #2985 )sentry-springandjsonevent-layoutm2 profiles when generating the official docker images (the actual purpose of this PR). The overhead on the generated artifact is less than 1MB, so even if it is not used by the final user, it seems to provide an interesting added value to the webapps, allowing to plug them to external tools (sentry, logstash/kibana and so on).