Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove init-method and use PostConstruct annotation #2999

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

RemiDesgrange
Copy link
Contributor

Close #2504.

I also could not resist refactor this little lambda :-)

@fvanderbiest
Copy link
Member

mfapp and sp do not build ?

@RemiDesgrange
Copy link
Contributor Author

See #3000

@fvanderbiest fvanderbiest self-requested a review March 23, 2020 16:01
@RemiDesgrange
Copy link
Contributor Author

@fvanderbiest I'm going to wait for CI to work again, then I'll merge this.

@fvanderbiest
Copy link
Member

fvanderbiest commented Apr 1, 2020

mapfishapp builds not, "ImportError: No module named virtualenv"
We might miss something like

    - name: "Setting up Python 2.x"
      uses: actions/setup-python@v1
      with:
        python-version: '2.x'

    - name: "Installing jsbuild and virtualenv"
      run: |
        pip install jsbuild
        pip install virtualenv

in https://github.com/georchestra/georchestra/blob/master/.github/workflows/mapfishapp.yml

@landryb
Copy link
Member

landryb commented Apr 1, 2020

mapfishapp builds not, "ImportError: No module named virtualenv"

i had do do something similar in cadastrapp as it also uses jsbuild (from last millenium), maybe you want to reuse it.

@fvanderbiest
Copy link
Member

i had do do something similar in cadastrapp as it also uses jsbuild (from last millenium), maybe you want to reuse it.

Comes from there ;-)

@fvanderbiest fvanderbiest self-requested a review April 1, 2020 14:02
Close #2504. I also could not resist refactor this little lambda :-)
@RemiDesgrange RemiDesgrange force-pushed the 2504-replace-init-method-by-postconstruct branch from 95c7540 to bcf9ed2 Compare April 1, 2020 14:41
@RemiDesgrange
Copy link
Contributor Author

I forgot to rebase on master. Now OK

@fvanderbiest fvanderbiest merged commit c932845 into master Apr 1, 2020
@fvanderbiest fvanderbiest deleted the 2504-replace-init-method-by-postconstruct branch April 1, 2020 14:57
@fvanderbiest
Copy link
Member

Thanks !

@fvanderbiest fvanderbiest added this to the 20.1.0 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Spring init-method configuration parameter by @PostConstruct annotation
3 participants