Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapfishapp - Fix tests dependency fail introduceda while ago #3011

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

RemiDesgrange
Copy link
Contributor

it seems to be introduced by
0da5782#diff-acb8fe7e00154b6e6b35bb938c4c4bba
but ant was never a direct dep of the project, it was transitive, so harder to find.

@RemiDesgrange RemiDesgrange changed the title Fix tests dependency fail introduceda while ago Mapfishapp - Fix tests dependency fail introduceda while ago Mar 27, 2020
@pmauduit
Copy link
Member

it seems to be introduced by
0da5782#diff-acb8fe7e00154b6e6b35bb938c4c4bba
but ant was never a direct dep of the project, it was transitive, so harder to find.

Actually this is the recent update of urlrewritefilter from org.tuckey which does not depend anymore to ant:

#2975

see:
https://mvnrepository.com/artifact/org.tuckey/urlrewritefilter/3.0.4
vs
https://mvnrepository.com/artifact/org.tuckey/urlrewritefilter/4.0.4

where ant becomes optional.

@pmauduit pmauduit merged commit 4692099 into master Mar 27, 2020
@pmauduit pmauduit deleted the fix-compile-on-mapfishapp branch March 27, 2020 14:25
@fvanderbiest fvanderbiest added this to the 20.1.0 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants