Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all webapps - remove sentry-spring / reintroduce sentry-log4j #3030

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

pmauduit
Copy link
Member

@pmauduit pmauduit commented Apr 8, 2020

Quoting the sentry doc:

A Sentry logging integration is more general and will capture errors
(and possibly warnings, depending on your configuration) that occur
inside or outside of a Spring controller. In most scenarios, using one
of the logging integrations instead of sentry-spring is preferred.

https://docs.sentry.io/clients/java/integrations/#spring

Which is actually what we did in the first place.

Quoting the sentry doc:

A Sentry logging integration is more general and will capture errors
(and possibly warnings, depending on your configuration) that occur
inside or outside of a Spring controller. In most scenarios, using one
of the logging integrations instead of sentry-spring is preferred.

https://docs.sentry.io/clients/java/integrations/#spring

Which is actually what we did in the first place.
@RemiDesgrange
Copy link
Contributor

What will we send to sentry then ? Is usage is for crash report/stack trace, I don't know if log4j integration will send it properly 🤔 I need to test this to understand.

@pmauduit
Copy link
Member Author

pmauduit commented Apr 9, 2020

What will we send to sentry then ? Is usage is for crash report/stack trace, I don't know if log4j integration will send it properly I need to test this to understand.

Following the sentry doc I pointed and from my understanding, it is more relevant to use the logger to send things to sentry, as we should be able to get more "things" than from the Spring's HandlerExceptionResolver. I don't know the details either, but my feeling would be to follow Sentry's official doc.

From the log4j configuration, I think that introducing a sentry logger which would be configured on ERROR level should be ok. If we got too much things from there, the issue might not be the configuration, but the way we are logging things.

@fvanderbiest fvanderbiest merged commit edc8525 into master Apr 14, 2020
@fvanderbiest fvanderbiest deleted the sentry-log4j-instead-of-spring branch April 14, 2020 09:39
@fvanderbiest
Copy link
Member

to backport to 20.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants