refix debian package version, matching on branch name instead of SNAPSHOT #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SHOT same change done with 5409a10 in master branch followup to 993e7c7, 0715664 and georchestra#3709 with that, the logic is: - on stable branches (eg matching \d{2}\.\d\.x$, so 20.1.x, 22.0.x...) start the package version with the closest tag name - on other branches (master, pull requests, experimental branches..) use 99.master tested with the diff local on 22.0.x, dpkg --info on the resulting debs gives me the expected 'Version: 22.0.0.202204071436~ae8bbaf' for all georchestra packages (but geonetwork) on the master branch with 5409a10, i get Version: 99.master.202204071442~5409a10
pmauduit
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #3711
same change done with 5409a10 in master branch
followup to 993e7c7, 0715664 and #3709
with that, the logic is:
tested with the diff local on 22.0.x, dpkg --info on the resulting debs gives
me the expected
Version: 22.0.0.202204071436~ae8bbaffor all georchestrapackages (but geonetwork)
on the master branch with 5409a10, i get
Version: 99.master.202204071442~5409a10