Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize MOM MS3 - Phase I #425

Closed
offtherailz opened this issue Nov 9, 2021 · 15 comments
Closed

Finalize MOM MS3 - Phase I #425

offtherailz opened this issue Nov 9, 2021 · 15 comments

Comments

@offtherailz
Copy link
Collaborator

offtherailz commented Nov 9, 2021

At the end of development for issues of MOM MS3, create a new stable branch for mapstore2-georchestra (1.3.x) and tag the version 1.3.0.

@tdipisa
Copy link
Collaborator

tdipisa commented Dec 10, 2021

@catmorales as per this issue description we can use the same naming convention we used until now for stable branch/tag (1.3.x/1.3.0). Anyway, according to what discussed in #422 before, if you want to use a different convention this is the right moment to confirm that definitely. What should we use? We are looking forward to hearing from you before proceeding on this.

@landryb
Copy link
Member

landryb commented Dec 10, 2021

as far as i'm concerned, #422 (comment) is what should be done, branch 20.1.x.

@tdipisa tdipisa changed the title Finalize MOM MS3 Finalize MOM MS3 - Phase I Dec 10, 2021
@tdipisa
Copy link
Collaborator

tdipisa commented Dec 10, 2021

as far as i'm concerned, #422 (comment) is what should be done, branch 20.1.x.

I suppose to, we just need a confirmation from the georchestra team.

@catmorales
Copy link
Collaborator

@pmauduit , @fvanderbiest could you confirm the Landry's proposition ?

@fvanderbiest
Copy link
Member

Jumping in, sorry I'm late to the game.

20.1.x is the latest stable branch from 2020.
There was no major release last year (2021) but a 22.0.0 release is planned this month if everything goes well.

Should MapStore-georchestra be tagged as geOrchestra itself ?
That's a good question.

IIUC, this MS3 contract's main purpose was to upgrade to MapStore 2021.02.xx which is mapstore's latest stable release and provides new features compared to the older one we had in geOrchestra.
If we stick to geOrchestra habits, this should not happen on the 20.1.x branch (which is only meant for bugfixes on 20.1.0).
Instead this should be part of the next major release (22.0.0).

The reason why I'm questioning the same-tag-as-georchestra motto is that we probably do not want to delay a mapstore-georchestra release because we're late releasing geOrchestra 22. Also, it probably makes sense to keep the tags aligned with upstream mapstore, to keep it simple-to-follow.

Other opinions welcome here.

@landryb
Copy link
Member

landryb commented Jan 5, 2022

agreed on "not delaying", but iirc ppl wanted to have a consistent set of things be a part of a georchestra release, eg tagging the ms2-geor repo when the geor repo was tagged for a release.. really, i don't care if the branch name is 2021.02.xx or 22.0.x or 1.3.x, it's just a branch name :) please someone pick something and stick to it :D

@fvanderbiest
Copy link
Member

fvanderbiest commented Jan 5, 2022

iirc ppl wanted to have a consistent set of things be a part of a georchestra release

If we split modules in several repositories, which is the trend geOrchestra is currently following, it will be more and more difficult to keep releases aligned. As a result, I would vote for tags aligned with upstream mapstore.
We'll have to provide a compatibility table at some point.

@catmorales
Copy link
Collaborator

Hello @tdipisa , @offtherailz
To answer this question and to finish on this point, we finally decided to align ourselves with the versions of mapstore2 so this one would be 2021.02.xx.

@tdipisa
Copy link
Collaborator

tdipisa commented Jan 13, 2022

@catmorales ok we will proceed with this, the new stable branch of ms2-ge will be 2021.02.xx. Independent tags for project minor releases can be done starting from this when needed according to the ms2-ge release schedule.

@tdipisa
Copy link
Collaborator

tdipisa commented Jan 17, 2022

@catmorales since we have already merged #436 on master, we will proceed to create the new stable branch after functional tests in our DEV instance (fyi @offtherailz).

@catmorales
Copy link
Collaborator

@tdipisa I'd like to test the last improvements in pedestrian view but i need this new stable branch in your docker images repository to do it. I wanted to test it before sending you the VA document for this phase. Will it be possible to have it today ? Otherwise, i'll put a reserve on it

@tdipisa
Copy link
Collaborator

tdipisa commented Jan 18, 2022

@tdipisa I'd like to test the last improvements in pedestrian view but i need this new stable branch in your docker images repository to do it. I wanted to test it before sending you the VA document for this phase. Will it be possible to have it today ? Otherwise, i'll put a reserve on it

Ok, I'm managing for this now. I will let you know as soon as possible.

@tdipisa
Copy link
Collaborator

tdipisa commented Jan 18, 2022

@catmorales branch created and image available in docker hub

@tdipisa tdipisa closed this as completed Jan 19, 2022
@fvanderbiest
Copy link
Member

From a "geOrchestra project" point of view, it would also make sense to have an image tagged in https://hub.docker.com/r/georchestra/mapstore IIUC

@catmorales
Copy link
Collaborator

@tdipisa I've deployed this docker image this morning on portail-test:


$ docker ps | grep mapstore
29b9b7a3b288   geosolutionsit/mapstore2-georchestra:2021.02.xx                             "/.r/r catalina.sh r…"   4 hours ago     Up 3 hours                                                  r-georchestra-mapstore-1-8ad12ffa
  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants