Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MapStore 2021.02.xx #422

Closed
1 task done
offtherailz opened this issue Nov 9, 2021 · 11 comments
Closed
1 task done

Update to MapStore 2021.02.xx #422

offtherailz opened this issue Nov 9, 2021 · 11 comments

Comments

@offtherailz
Copy link
Collaborator

offtherailz commented Nov 9, 2021

We have to also include the following:

  • Update of the georchestra MS project master to point to latest MapStore stable 2021.02.xx
@offtherailz offtherailz added this to the MOM MS3 milestone Nov 9, 2021
@offtherailz offtherailz self-assigned this Nov 9, 2021
@tdipisa tdipisa added Contract #3 Task enhancement New feature or request labels Nov 9, 2021
@catmorales
Copy link
Collaborator

Tag the current version on branch 1.2.x with a fixed version

We will have to take advantage of this evolution to tighten up the naming of versions, tags, bugfixes and docker images.
Can we already rely on year-version-bufix on the tag ? It seems to me that this is what you had started on https://github.com/georchestra/mapstore2-georchestra/tags.
@tdipisa , @offtherailz What do you think and do you have any constraints at this level?

@fvanderbiest , @landryb , @pmauduit could you give the better recommandations to be in agreement with geOrchestra?

@landryb
Copy link
Member

landryb commented Nov 16, 2021

i'm not a specialist in release management, but i'd say the 'stable' branch of mapstore2-georchestra should be in a releaseable state all the time, and get tagged everytime a georchestra release is tagged/done (eg 20.1.4, 21.0.x, etc).. And since the repo/project is "a bit" independent, it could still get bugfixes and tags separately (eg doesnt "need" a new full georchestra release at each bugfix batch, just tag this repo with 20.1.4.1 21.0.x.1 etc)

@offtherailz
Copy link
Collaborator Author

Ok, accordingly with the current status I have the tag 20.1.3-georchestra, then a series of commit from your team.

image

I suggest to create a stable branch 20.1.x, and then continue development on master for future release, back-porting all bug fixes.
Please tell me from witch commit I should create the branch, after the tag (included).

@landryb
Copy link
Member

landryb commented Nov 16, 2021

i'll defer to @fvanderbiest as i'm not 100% aware of camptocamp's strategy wrt submodules/merges/backports/etc..

@MaelREBOUX
Copy link
Member

Hello @offtherailz

The PSC recommend to now name the tags and releases of mapstore2-georchestra in the same way as geOrchestra does.
I think it is very close of the rules for MapStore2.

The doc which describe the release system is here : https://github.com/georchestra/georchestra/blob/master/docs/releases.md

One more thing, please, in the release text, add the info of the mapstore2 backport release to be clear on which version is used.

@offtherailz
Copy link
Collaborator Author

offtherailz commented Nov 18, 2021

Does it makes sense to do this operation or should I proceed only on master ?

  • rename the current 1.2.x into 20.1.x
  • Commit the pom on stable in 20.1.0 (or 1 and tag previous)
  • Then tag it with a release (please indicate the commit you are actually using)
  • Commit again pom on stable in 20.1-SNAPSHOT.

@landryb
Copy link
Member

landryb commented Nov 19, 2021

yes that seems sensible (@pmauduit ? you're the maven expert), right now the last release is https://github.com/georchestra/georchestra/releases/tag/20.1.4

@landryb
Copy link
Member

landryb commented Nov 29, 2021

fwiw, successfully tested update from #428 on my dev instance, will test runtime now (really nicer compact menus and better default font !). depends on georchestra/datadir#224 merge too.

@jusabatier
Copy link
Contributor

Also tested here, I have my uploaded plugins that have disappear.

They still in the extensions directory, but it looks like Mapstore can't find them.

I also have this in logs :

PropertiesLoaderSupport.loadProperties() - Could not load properties from URL [file:/mapstore.properties]: /mapstore.properties (Aucun fichier ou dossier de ce type)

@jusabatier
Copy link
Contributor

Here : https://github.com/georchestra/mapstore2-georchestra/search?q=mapstore.properties

Should look in ${georchestra.datadir}/mapstore/mapstore.properties

@offtherailz
Copy link
Collaborator Author

Please make sure to do these operations:

https://mapstore.readthedocs.io/en/latest/developer-guide/mapstore-migration-guide/#data-directory-has-been-reorganized-and-is-now-available-also-for-product

  • Move all .json and .json.patch files in configs folder (except extensions.json)
  • Move the directory dist/extensions to simply extensions.
  • The file extensions.json have to be moved in extensions/extensions.json.
  • Edit the file extensions/extensions.json changing the paths from dist/extensions/<Plugin-Name>/... to <Plugin-Name>/...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants