Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not ORDER BY a column from a FUNCTION #1119

Closed
2 tasks done
xzdandy opened this issue Sep 14, 2023 · 1 comment
Closed
2 tasks done

Can not ORDER BY a column from a FUNCTION #1119

xzdandy opened this issue Sep 14, 2023 · 1 comment
Labels
Bug 🐞 EVA is not working as expected
Milestone
v0.3.5

Comments

@xzdandy
Copy link
Collaborator

xzdandy commented Sep 14, 2023

Search before asking

  • I have searched the EvaDB issues and found no similar bug report.

Bug

cursor.query("SELECT HomeSaleForecast(3) ORDER BY ma;").df()

crashed with the following errors:

09-14-2023 06:17:03 ERROR [statement_binder_context:statement_binder_context.py:raise_error:0147] Found invalid column ma
ERROR:evadb.utils.logging_manager:Found invalid column ma
---------------------------------------------------------------------------
BinderError                               Traceback (most recent call last)
[<ipython-input-15-b8688bcf0d02>](https://localhost:8080/#) in <cell line: 1>()
----> 1 cursor.query("SELECT HomeSaleForecast(3).ma ORDER BY MA;").df()

8 frames
[/usr/local/lib/python3.10/dist-packages/evadb/binder/statement_binder_context.py](https://localhost:8080/#) in raise_error()
    146             err_msg = f"Found invalid column {col_name}"
    147             logger.error(err_msg)
--> 148             raise BinderError(err_msg)
    149 
    150         if not alias:

BinderError: Found invalid column ma

Environment

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@xzdandy xzdandy added the Bug 🐞 EVA is not working as expected label Sep 14, 2023
@xzdandy xzdandy added this to the v0.3.5 milestone Sep 14, 2023
@xzdandy xzdandy self-assigned this Sep 14, 2023
@xzdandy xzdandy mentioned this issue Sep 14, 2023
Merged
2 tasks
xzdandy added a commit that referenced this issue Sep 15, 2023
@xzdandy
Add a model forecasting notebook in tutorials (#1118)
5858f8d 
Add a notebook for forecasting.

Blocked by
- [x] #1117 Bypassed by installing evadb from a commit before the PR.
- [x] #1119 Bypassed by using a nested SQL query, will improve later.

This PR adds a basic version of notebook for forecasting. We have also
found several issues we need to improve in later PRs:
**EvaDB related:**
1. Nested SQL query must have AS, which is redundant.
2. Can not order by a column which is the function's output from the
projection's target list.
3. When we are tuning the parameters that used for training, we need to
run the drop function every time.

**Statsforecast integration related:**
1. Math domain error with statsforecast, when we want to forecast
property prices for different postcode.
2. Auto inferring frequency never works.
3. Changing the frequency does not seem to affect the output of the
forecasting value, which is unexpected.
5. The catalog column can only be one column, so we need to train three
different models for postcode, bedrooms, and propertytype. We should be
able to train one model for every combination of these columns.
@xzdandy xzdandy removed their assignment Sep 15, 2023
@xzdandy xzdandy mentioned this issue Sep 15, 2023
Closed
2 tasks
@xzdandy
Copy link
Collaborator Author

xzdandy commented Sep 15, 2023

#1130 will fix this issue.

@xzdandy xzdandy closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 EVA is not working as expected
Projects
None yet
Milestone
v0.3.5
Development

When branches are created from issues, their pull requests are automatically linked.

1119-can-not-order-by-a-column-from-a-function georgia-tech-db/evadb
1 participant
@xzdandy