Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a model forecasting notebook in tutorials #1118

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

xzdandy
Copy link
Collaborator

@xzdandy xzdandy commented Sep 14, 2023

Add a notebook for forecasting.

Blocked by

This PR adds a basic version of notebook for forecasting. We have also found several issues we need to improve in later PRs:
EvaDB related:

  1. Nested SQL query must have AS, which is redundant.
  2. Can not order by a column which is the function's output from the projection's target list.
  3. When we are tuning the parameters that used for training, we need to run the drop function every time.

Statsforecast integration related:

  1. Math domain error with statsforecast, when we want to forecast property prices for different postcode.
  2. Auto inferring frequency never works.
  3. Changing the frequency does not seem to affect the output of the forecasting value, which is unexpected.
  4. The catalog column can only be one column, so we need to train three different models for postcode, bedrooms, and propertytype. We should be able to train one model for every combination of these columns.

@xzdandy xzdandy added this to the v0.3.5 milestone Sep 14, 2023
@xzdandy xzdandy self-assigned this Sep 14, 2023
@xzdandy xzdandy linked an issue Sep 14, 2023 that may be closed by this pull request
2 tasks
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@xzdandy xzdandy marked this pull request as ready for review September 15, 2023 05:55
@xzdandy xzdandy merged commit 5858f8d into staging Sep 15, 2023
@xzdandy xzdandy deleted the 1063-add-a-model-forecasting-notebook-in-tutorials branch September 15, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a model forecasting notebook in tutorials
2 participants