fix: insert and delete executor #611
Conversation
* fix to insert and delete executor * variable names * removing unnecessary arrays * use SQLalchemy for delete execution predicates * formatting * moving delete_predicate to expression_utils * formatting
aryan-rajoria
changed the title
aryan-rajoria
changed the title
|
@aryan-rajoria |
jarulraj
changed the title
|
@aryan-rajoria I brought the PR up-to-date with master. Please pull in the latest changes. |
|
This delete statement does not work -- """DELETE FROM testDeleteOne WHERE id < 20 AND dummyfloat < 2;""" |
This is now resolved. All the tasks have been completed. |
eva/expression/expression_utils.py
Outdated
| elif predicate_node.etype == ExpressionType.COMPARE_LEQ: | ||
| filter_clause = x <= y | ||
| elif predicate_node.etype == ExpressionType.COMPARE_NEQ: | ||
| filter_clause = x != y |
There was a problem hiding this comment.
CONTAINS and IS_CONTAINED are not supported here. We can check and raise exception if they are non-trivial.
eva/storage/sqlite_storage_engine.py
Outdated
|
|
||
| filter_clause = predicate_node_to_filter_clause( | ||
| table=table_to_delete_from, predicate_node=where_clause | ||
| ) |
There was a problem hiding this comment.
Nit: I feel it is better to move predicate_node_to_filter_clause logic into delete_executor and the delete_executor accepts the ColumnElement[bool] as the input argument (i.e., where_clause). ColumnElement[bool] is the return type of and_ and or_
There was a problem hiding this comment.
Good idea. Moved it to delete_executor
Fixing issues in insert and delete executor based on feedback from @gaurav274
insert_executor._roll_backfrom the executors.delete_executorusing the SQLAlchemy.single_predicate_to_filter()to ExpressionUtils.ANDandOR)single_predicate().