Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGR Layer: Set Attribute Filter & Set Spatial Filter as Rectangle #200

Merged
merged 5 commits into from
Jul 28, 2021

Conversation

ChristianBeilschmidt
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

I've added two new functions to the OGR layer wrapper that call…

  • OGR_L_SetAttributeFilter
  • OGR_L_SetSpatialFilterRect

I've also added tests so that we can see that they work.

src/vector/layer.rs Outdated Show resolved Hide resolved
@lnicola
Copy link
Member

lnicola commented Jul 28, 2021

r? @jdroenner

(I have merge, but not bors rights 😄)

@jdroenner jdroenner merged commit 8facee4 into georust:master Jul 28, 2021
@jdroenner
Copy link
Member

@lnicola i never use bors. how do i grant bors rights?

@lnicola
Copy link
Member

lnicola commented Jul 28, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 28, 2021

🔒 Permission denied

Existing reviewers: click here to make lnicola a reviewer

@jdroenner
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 28, 2021

🔒 Permission denied

Existing reviewers: click here to make jdroenner a reviewer

@jdroenner
Copy link
Member

XD

@lnicola
Copy link
Member

lnicola commented Jul 28, 2021

Oh, that clears it up 😄.

@jdroenner
Copy link
Member

i think its an issue caused by github teams

@lnicola
Copy link
Member

lnicola commented Jul 28, 2021

I think bors is configured separately from GitHub -- you can grant rights to someone without adding them to any GitHub team.

@jdroenner
Copy link
Member

yes but there is no reviewer and i think an owner of the repo hast to grand initial rights. However, i'm only in the gdal team not an owner of the repo.

@lnicola
Copy link
Member

lnicola commented Jul 28, 2021

@notriddle hey, I was wondering if you happen to know how or when bors was set up on https://app.bors.tech/repositories/34, given its low id. Around 2017, maybe?

I think we're in a bit of a pickle regarding the ownership of the integration.

EDIT: never mind, we figured it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants