Fix deprecations from chrono 0.4.23. #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, and we don't even support Looks good, I suppose, but I'd like someone else to take a look, as I'm pretty rusty on both the chrono API and the OGR data types. |
lnicola
approved these changes
Nov 15, 2022
lnicola
reviewed
Nov 15, 2022
|
@jdroenner, @ttencate or @ChristianBeilschmidt: would one of you have the time to review this? 🙏 |
extra space Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
|
@metasim Not me, sorry. I'm just an occasional contributor, not a maintainer, and don't have time to do more at the moment :) |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 16, 2022
336: Fix deprecations from chrono 0.4.23. r=metasim a=metasim - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Fixes #335 Co-authored-by: Simeon H.K. Fitch <fitch@astraea.io>
|
Build failed: |
|
Blocked by #337 |
|
I am so sorry. 🙈 |
LoL 🔥 🧑🚒 😆 |
metasim
added
dependencies
metasim
added a commit
to metasim/gdal
that referenced
this pull request
Nov 19, 2022
2 tasks
|
bors r+ |
metasim
added a commit
to metasim/gdal
that referenced
this pull request
Nov 20, 2022
* master: Hold back geo-types version; deprecations addressed in georust#339 Fixes deprecations introduced in geo-types v0.7.8. Hold back chrono version, as it's addressed in georust#336 Update .cargo/config.toml Fix deprecations from chrono 0.4.23.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Fixes #335