Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trait object arguments for MapCoord traits. #407

Merged
merged 2 commits into from
Dec 28, 2019
Merged

Remove trait object arguments for MapCoord traits. #407

merged 2 commits into from
Dec 28, 2019

Conversation

frewsxcv
Copy link
Member

Now callers don't need to pass a reference to a closure, they can just
pass the closure. No performance difference.

@frewsxcv
Remove trait object arguments for MapCoord traits.
20a083c 
Now callers don't need to pass a reference to a closure, they can just
pass the closure. No performance difference.
@frewsxcv
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Dec 28, 2019
@bors @frewsxcv
Merge #407
5167002 
407: Remove trait object arguments for MapCoord traits. r=frewsxcv a=frewsxcv

Now callers don't need to pass a reference to a closure, they can just
pass the closure. No performance difference.

Co-authored-by: Corey Farwell <coreyf@rwell.org>
@bors
Copy link
Contributor

bors bot commented Dec 28, 2019

Build failed

@frewsxcv
Copy link
Member Author

bors r+

@frewsxcv
Copy link
Member Author

yay for ci catching a bug!

bors bot added a commit that referenced this pull request Dec 28, 2019
@bors @frewsxcv
Merge #407
a3ef27e 
407: Remove trait object arguments for MapCoord traits. r=frewsxcv a=frewsxcv

Now callers don't need to pass a reference to a closure, they can just
pass the closure. No performance difference.

Co-authored-by: Corey Farwell <coreyf@rwell.org>
@bors
Copy link
Contributor

bors bot commented Dec 28, 2019

Timed out

@frewsxcv frewsxcv merged commit feb6de4 into master Dec 28, 2019
@frewsxcv frewsxcv deleted the frewsxcv-map branch December 28, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frewsxcv