Use XML tag "desc" instead of "description" #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the GPX schema and should fix georust#48.
|
As mentioned in #46, the Travis failure is due to a rustfmt on nightly issue. |
|
Thanks for this @cassaundra! Could you update the changelog and then I'll merge this? |
|
@urschrei Done. Thank you! |
|
Bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description field of the metadata type is parsed and written with the "description" tag instead of "desc." I believe this is an error, as all other description fields in the crate follow the schema correctly for this field. This pull request resolves that discrepancy and should fix #48.
Schema reference: 1.0/1.1