New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GEOS-Chem "History" diagnostics in CESM-GC #11
Support GEOS-Chem "History" diagnostics in CESM-GC #11
Conversation
… and was added in error
The new GEOS-Chem PR that goes with this is geoschem/geos-chem#1509. I closed out the old one so that we could bring it into 14.0.2, and so that I could push updates to it as well. The file no longer includes any wildcards (several had just a few tags so I manually put them in, and the others I just put ozone), and I removed most of the budget diagnostics since the components they are from are not used in CESM. I also removed the convection diagnostics. I tested out the new file using this branch, turning all GEOS-Chem collections on, thereby enabling allocation of all diagnostics listed in the file. I then added at least one diagnostic from each GEOS-Chem collection to The workflow to turn on diagnostics in GEOS-Chem and output in CESM actually wasn't too bad. I did run into issues where I miscopied some of the GEOS-Chem diagnostic names to I looked at the output values for all of the GEOS-Chem diagnostics I added to
@jimmielin, I can add these in after merging this PR. Or if you want to put them in CAM for this update that works too. |
Thanks Lizzie!
Yes. There are guides here for some CAM-chem output, https://wiki.ucar.edu/display/camchem/Using+CAM-chem+Output, but the real resource lies in the "master field list", which is in Apologies for missing the aerosol mass diagnostics code. Please feel free to put them in after merging the PR, I forgot that they're not set together from within Thanks! |
…2D for 3D and 2D data.
No longer needs to allocate temporaries. I checked and diagnostics have values as expected, except the ones which correspond to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the allocation. This is much better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making all the changes. Ready for merge.
This is based-off GCHP's
gchp_historyexports_mod.F90
to createcesmgc_history_mod.F90
.It will support any GEOS-Chem diagnostic in
HISTORY.rc
(without wildcards) to be output in CAM history. The names will be the same.Notes:
GC/run/CESM
will need to be used to remove wildcards and write out everything explicitly. A companion PR in the GEOS-Chem science repository is here: Update CESM/HISTORY.rc geos-chem#1480cam_history_support.F90
has been changed to make the maximum field length32
chars. A companion PR in the ESCOMP/CAM repository to request CAM to update this upstream is here: part of cam6_3_084 : Update maximum CAM history field length to 32 (up from 24). ESCOMP/CAM#686cesmgc_diag_mod.F90
to remove obsolete code. I've commented out the sections adding theJval_
diagnostics, as they have been fully superceded bycesmgc_history_mod.F90
.