Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESMF 8.0.0 doesn't include ESMF_CS_Arguments in esmf.mod #2

Closed
LiamBindle opened this issue Oct 18, 2019 · 5 comments
Closed

ESMF 8.0.0 doesn't include ESMF_CS_Arguments in esmf.mod #2

LiamBindle opened this issue Oct 18, 2019 · 5 comments
Assignees
@LiamBindle
Labels
category: Bug Something isn't working

Comments

@LiamBindle
Copy link
Contributor

LiamBindle commented Oct 18, 2019 •
edited
Loading

The build with ESMF 8.0.0 official release is failing because use ESMF doesn't define the ESMF_CS_Arguments type which is used in MAPL_Base/MAPL_CubedSphereGridFactory.F90.

I'm looking into this...
@LiamBindle LiamBindle added the category: Bug Something isn't working label Oct 18, 2019
@LiamBindle
Copy link
Contributor Author

LiamBindle commented Oct 18, 2019 •
edited
Loading

Changes in the 8.0.0 official release (since RC version we were using):

  • type(ESMF_CS_Arguments) -> type(ESMF_CubedSphereTransform_Args)
  • ESMF_GridCreateCubedSphereReg() argument transformArguments -> transformArgs

@LiamBindle
Copy link
Contributor Author

Here's the fix: https://github.com/geoschem/MAPL/tree/fix/renamed-cs-args-for-esmf8

@lizziel
Copy link
Contributor

lizziel commented Oct 18, 2019

Is this backwards compatible with the earlier beta versions of 8?

@LiamBindle
Copy link
Contributor Author

LiamBindle commented Oct 18, 2019 •
edited
Loading

No unfortunately not. The ESMF_CS_Arguments type's named changed, as well as the keyword argument transformArguments to ESMF_GridCreateCubedSphereReg()—they don't exist in ESMF 8, and ESMF 8 pre-releases don't have the new names.

@LiamBindle LiamBindle self-assigned this Oct 18, 2019
@LiamBindle
Copy link
Contributor Author

Closed with 3f06a1b

@gopikrishnangs44 gopikrishnangs44 mentioned this issue Mar 22, 2022
Closed
yantosca added a commit that referenced this issue Nov 10, 2022
@yantosca
HEMCO submod update: Remove memory leaks identified by the code sanit…
4997ac7 
…izer

This commit informs the GCHP superproject about the following
commits that were pushed to the GitHub geoschem/HEMCO repository:

ee75832 Removed commented-out unused code in hcox_dustdead_mod.F471fa19 Added text re: sanitizer option for HEMCO standalone to CHANGELOG.md
b404ae1 Moved memory leaks text in CHANGELOG.md from "Changed" to "Fixed"
09b8db6 Updated CHANGELOG to reflect removal of memory leaks
5be2f32 Bug fix: Nullify Inst%GFED_EMFAC instead of deallocating it
2d56ee9 Merge branch 'main' into feature/sanitize+3.5.1
7ed469e Prevent memory leaks in routine ConfigList_AddCont (hco_config_mod.F90)
04f3278 Remove deallocation statement in hco_datacont_mod.F90
d53a5b0 Remove memory leak in hco_datacont_mod.F90 and hco_filecont_mod.F90
a9a14fc Fix memory leaks in HEMCO core routines
5120eae Add -DSANITIZE=y option to CMakeLists.txt for HEMCO standalone
7e1e171 Clean up memory leaks in extension InstRemove routines #2
1efde62 Clean up memory leaks in extension "InstRemove" routines
fd6f78f Free pointer fields of HcoState%Clock in routine HcoClock_Cleanup

This brings into the GCHP 14.0.2 development stream code that has
been sanitized to remove memory leaks.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@lizziel lizziel mentioned this issue Mar 17, 2023
Closed
2 tasks
yantosca added a commit that referenced this issue Mar 18, 2024
@yantosca
Cloud-J submod update: Merge PR #2, PR #9, PR #10
ca1196c 
This commit informs the GCHP superproject about the following
commits that were pushed to the GitHub geoschem/Cloud-J repository:

3162ea8 Merge pull request #2 from geoschem/geos-chem
1905283 Merge pull request #10 from K20shores/ubuntu_badge
50c79b4 Merge pull request #9 from K20shores/actions

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LiamBindle LiamBindle

Labels
category: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lizziel @LiamBindle