Now use short submodule names in .gitmodules #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.gitmodules - The geos-chem-shared-docs submodule should be named "docs/source/geos-chem-shared-docs" to be consistent with its path - The Cloud-J submodule should be "src/GCHP_GridComp/Cloud_J", to be consistent with its path CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
category: Bug
.gitmodules - Use short names (i.e. only the name of the module and not of the entire path) for submodules CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
changed the title
yantosca
changed the title
lizziel
approved these changes
Mar 18, 2024
yantosca
added a commit
that referenced
this pull request
Mar 18, 2024
This merge brings PR #396 (Add GCHP_WRAPPER cpp definition, by @lizziel) into the GEOS-Chem "no-diff-to-benchmark" development stream. This fixes an compiliation issue in Cloud-J, which occurred because the GCHP_WRAPPPER C-preprocessor setting was not defined in CMakeLists.txt. Thus we need to merge this PR before Cloud-J PR #10 and GCHP PR #394. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This is a minor update that fixes some incorrect submodule names in the
.gitmodulesfile. We have changed:to
This "future-proofs" the submodule names in case a submodule is moved to a different path.
Expected changes
This is a zero-diff update,
Related Github Issue(s)
NOTE: This PR should be merged immediately after: