Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Longitudinal grids for HEMCO standalone (0.25 x 0.3125, 0.5 x 0.625) #228

Closed
4 tasks done
nicholasbalasus opened this issue Jul 19, 2023 · 2 comments · Fixed by #229
Closed
4 tasks done

[Bugfix] Longitudinal grids for HEMCO standalone (0.25 x 0.3125, 0.5 x 0.625) #228

nicholasbalasus opened this issue Jul 19, 2023 · 2 comments · Fixed by #229
Assignees
@yantosca
Labels
category: Bug Something isn't working never stale Never label this issue as stale
Milestone
3.7.1

Comments

@nicholasbalasus
Copy link
Contributor

Name and Institution (Required)

Name: Nick Balasus
Institution: Harvard University

Confirm you have reviewed the following documentation

Description of your issue or question

Currently, the values for XMIN and XMAX for 0.25°x0.3125° and 0.5°x0.625° give longitude grids that do not match up with meteorology/landcover/etc. files.

For 0.25°x0.3125°, this is the current setup:

HEMCO/run/HEMCO_sa_Grid.025x03125.rc

Lines 2 to 3 in 4e81881

XMIN: -180.125
XMAX: 179.875

I believe these should instead be:

XMIN: -180.15625
XMAX: 179.84375

These are calculated as -180 - 0.3125/2 and 180 - 0.3125/2.

For 0.5°x0.625°, this is the current setup:

HEMCO/run/HEMCO_sa_Grid.05x0625.rc

Lines 2 to 3 in 4e81881

XMIN: -180.25
XMAX: 179.75

I believe these should instead be:

XMIN: -180.3125
XMAX: 179.6875

These are calculated as -180 - 0.625/2 and 180 - 0.625/2.

This is similar to #71. However, I think that 0.25 x 0.3125 and 0.5 x 0.625 were given the wrong values. Tagging @ltmurray (opened the initial issue) in case I am confused!

I'll also note that the meteorology/land cover/etc. files go to latitude mid values of +/- 90 (which these standalone grids do not), but I think that is intentional based on comments in #71.
@yantosca yantosca added category: Bug Something isn't working never stale Never label this issue as stale labels Jul 19, 2023
@yantosca
Copy link
Contributor

Thanks @nicholasbalasus. I wonder if this also is related to the issue geoschem/geos-chem#1838. We will look into this but it may be a while.

@yantosca yantosca self-assigned this Jul 20, 2023
@nicholasbalasus nicholasbalasus mentioned this issue Jul 20, 2023
Closed
yantosca added a commit that referenced this issue Jul 20, 2023
@yantosca
Fix incorrect HEMCO_sa_Grid definitions for 0.5, 0.25 degree grids
69f93d2 
This commit applies the fixes suggested by @nicholasbalasus in
issue geoschem/hemco #228.

run/HEMCO_sa_Grid.025x03125.rc
- Change XMIN from -180.125 to -180.15625 (Western longitude edge)
- Change YMID from 179.875 to 179.84375 (Eastern longitude edge)
- Add explanatory comments

run/HEMCO_sa_Grid.05x0625.rc
- Change XMIN from -180.25 to -180.3125 (Western longitude edge)
- Change YMIN from 179.75 to 179.6875 (Eastern longitude edge)
- Add explanatory comments

run/HEMCO_sa_Grid.2x25
run/HEMCO_sa_Grid.4x5
- Add explanatory comments

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca mentioned this issue Jul 20, 2023
Merged
1 task
yantosca added a commit that referenced this issue Jul 21, 2023
@yantosca
Merge PR #229 (Fix incorrect longitude definitions for HEMCO standalone)
477c7e8 
This merge brings HEMCO PR #229 (Fix incorrect longitude definition in
HEMCO_sa_Grid.025x0625.rc and HEMCO_sa_Grid.05x0625.rc, by @yantosca)
into the HEMCO 3.7.1 development stream.  This resolves the issue
reported by @nicholasbalasus in #228.

Important features added:
- Now use proper settings for XMIN and XMAX in the files
  HEMCO_sa_Grid.05x0625.rc and HEMCO_sa_Grid.025x03125.rc
- Added explanatory comments

This only affectes HEMCO standalone simulations at 0.25x0.3125 or
0.5 x 0.625 horizontal resolutions.  GEOS-Chem and GCHP simulations
using HEMCO are not affected.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added this to the 3.7.1 milestone Jul 21, 2023
@yantosca
Copy link
Contributor

We can now close this issue as PR #229 has been merged into the 14.2.1 development stream.

@jiaying002 jiaying002 mentioned this issue Aug 1, 2023
Open
@nicholasbalasus nicholasbalasus mentioned this issue Dec 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yantosca yantosca

Labels
category: Bug Something isn't working never stale Never label this issue as stale
Projects
None yet
Milestone
3.7.1
2 participants
@yantosca @nicholasbalasus