Enable use of _FillValue for identifying missing values in input files #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizziel
added
enhancement
|
This PR should not be merged until after geoschem/geos-chem#1255. |
|
This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue. |
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This update also include minor changes to how fname set in the metadata utilities file. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
feature/FillValue_handling_fix
branch
from
930b556
to
98b7785
Compare
lizziel
requested review from
Jourdan-He and
msulprizio
and removed request for
LiamBindle and
Jourdan-He
|
The HEMCO PR that goes with this update is now ready for review at geoschem/HEMCO#171. I made @msulprizio reviewer for both since they go together. |
msulprizio
approved these changes
Oct 18, 2022
2 tasks
lizziel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is 1 of 2 for GCHP super-project. See instructions here:
geoschem/GCHP#258
Description
For single precision attribute retrieval there is now handling for double precision input. This update also expands error handling in FileMetadataUtilities to print filename in all calls to _ASSERT and _FAIL. Fail messages about unsupported attribute type now specify the unique type constraint per function.
Related Issue
Closes geoschem/GCHP#183
Motivation and Context
This update prevents run fail when retrieving _FillValue from import files containing double precision data used GCHP. It also expands the error handling so that failure on reading import attributes always results in a unique message with the filename, making it easier to find and fix the problem.
How Has This Been Tested?
Tested in GCHP branch with upgraded GMAO libraries going into 14.0.0.
Types of changes
Additional information / dependencies
In order for this update to fix GFAS there needs to be a modified version of one of the GEOS-Chem input files. I will submit that change as a GEOS-Chem repo PR.
These changes have been submitted to GMAO in GEOS-ESM#1506.