Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MAPL from 2.18.3 to 2.26.0 #23

Merged
merged 480 commits into from
Dec 8, 2022
Merged

Update MAPL from 2.18.3 to 2.26.0 #23

merged 480 commits into from
Dec 8, 2022

Conversation

lizziel
Copy link

@lizziel lizziel commented Nov 7, 2022

This pull request is part of a group of pull requests to update MAPL from 2.18.3 to 2.26.0 in GCHP. See instructions here: geoschem/GCHP#265

This pull request merges in MAPL 2.26.0. A few post-merge fixes had to be applied for compatibility with GCHP:

  1. Comment out version checks for yaFyaml and pFlogger. The required versions are still required (and are new - see below) but the checks do not catch that our forks contain them. We already had the version check for gFTL-shared commented out.
  2. Change the library type for new ExtData component ExtData2G from SHARED to ${MAPL_LIBRARY_TYPE}. GCHP does not used libraries with type SHARED. We made this change for several other libraries in the past.
  3. Do not add demo executables in component pfio and remove the pfio netCDF-C dependency. This dependency was added since 2.18.3 and it breaks the GCHP build. To fix the issue I simply removed the requirement by turning off the demos.

This version update requires a new field in GCHP config file CAP.rc. New entry USE_EXTDATA2G indicates whether to use input file ExtData.rc or a new file in yaml format. Using a yaml file has not yet been tested with GCHP but will be possible after this pull request is merged. The update to the GCHP run directory to include the new entry (set to false) is in geoschem/geos-chem#1489.

Also note that several Goddard-Fortran-Ecosystem libraries need version updates to go with this PR.
gFTL-shared: 1.5.0
yaFyaml: 1.0.4
pFlogger: 1.9.1

This update is a zero diff update for GCHP other than a new attribute in History output files. All output diagnostic fields now contain attribute regrid_method. This is true even if the output field is not regridded. The default value is bilinear. This field can be ignored, but it means you cannot do a straight diff of ref versus dev when testing this update except for the restart file. However, I verified that output values are the same for both diagnostic files and the restart.

This PR is going to have conflict with #21. I will update one or the other depending on the order in which they are merged.

mathomp4 and others added 30 commits May 31, 2022 07:33
…ninit-lperp

Hotfix 1530: Initialize lperp
…ge-main-into-develop-MAPL-2022May31

GitFlow: Handmerge main into develop (2022-May-31)
…e-cmake-to-3160-mapl

Update to ESMA_cmake v3.16.0
…extdata2g-missing-file

Fixes GEOS-ESM#1544. Adds _ASSERT for missing ExtData file
…ge-main-into-develop-MAPL-2022Jun07

Handmerge main into develop - 2022-Jun-07
…e-bundleio-ci

Enable bundleio tests in CI
mathomp4 and others added 22 commits September 9, 2022 14:34
…history-mode-protect

Fixes GEOS-ESM#1668. Only allow certain History modes
…dso_extension_assert

remove unnecessary DSO lib name assertion
…addchildfromdso-clean

Fixes GEOS-ESM#1598. Have AddChildFromDSO call Meta
…re-for-mapl-2260

Prepare for MAPL 2.26.0 Release
Merge Develop into Main (2.26 Release)
# Conflicts:
#	.github/workflows/changelog-enforcer.yml
#	.github/workflows/workflow.yml
#	CMakeLists.txt
#	base/FileMetadataUtilities.F90
#	gridcomps/Cap/MAPL_CapGridComp.F90
#	gridcomps/ExtData/ExtDataGridCompMod.F90
#	griddedio/GriddedIO.F90
#	pfio/CMakeLists.txt

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants