Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG/ISSUE] HEMCO config template for GCHP not setting Volcano_Table correctly #1350

Closed
kilicomu opened this issue Aug 12, 2022 · 6 comments
Closed

[BUG/ISSUE] HEMCO config template for GCHP not setting Volcano_Table correctly #1350

kilicomu opened this issue Aug 12, 2022 · 6 comments
Assignees
@lizziel
Labels
category: Bug Something isn't working topic: Configuration Files Related to GEOS-Chem configuration files topic: GCHP Related to GCHP only
Milestone
14.0.0

Comments

@kilicomu
Copy link
Contributor

What institution are you from?

Wolfson Atmospheric Chemistry Laboratories

Description of the problem

I think the Volcano_Table value in HEMCO_Config.rc as generated for GCHP run directories through createRunDir.sh is not being set correctly by default, and is missing $YYYY$MM$DD due to unescaped $ characters. I think the offending line is:

geos-chem/run/GCHP/createRunDir.sh

Line 232 in 7e51a06

RUNDIR_VARS+="RUNDIR_VOLC_TABLE='\$ROOT/VOLCANO/v2021-09/\$YYYY/\$MM/so2_volcanic_emissions_Carns.$YYYY$MM$DD.rc'\n"

and that it should be:

RUNDIR_VARS+="RUNDIR_VOLC_TABLE='\$ROOT/VOLCANO/v2021-09/\$YYYY/\$MM/so2_volcanic_emissions_Carns.\$YYYY\$MM\$DD.rc'\n"

Description of troubleshooting performed

Changed the value of Volcano_Table in HEMCO_Config.rc and the model can proceed.

GEOS-Chem version

7e51a06

Description of modifications

None

Log files

  • Build log (if applicable): N/A
  • Run logs (if applicable): See line 4935
    GCHP_TEST_19138514.log
  • Run script (if applicable): N/A

Software versions

  • CMake version: 3.15.3
  • Compilers (Intel or GNU, and version): Intel 19.0.5
  • NetCDF version: 4.5.2
@kilicomu kilicomu added the category: Bug Something isn't working label Aug 12, 2022
@kilicomu kilicomu changed the title [BUG/ISSUE] [BUG/ISSUE] HEMCO config template for GCHP not setting Volcano_Table correctly Aug 15, 2022
@yantosca yantosca added topic: GCHP Related to GCHP only topic: Configuration Files Related to GEOS-Chem configuration files labels Aug 16, 2022
@yantosca
Copy link
Contributor

Thanks @kilicomu. We can fix this for GC 14.0.1 as it seems a simple fix.

@yantosca yantosca added this to the 14.0.1 milestone Aug 22, 2022
yantosca added a commit that referenced this issue Aug 22, 2022
@yantosca
Fix typo in RUNDIR_VOLC_TABLE variable in run/GCHP/createRunDir.sh
5458939 
This commit fixes the issue raised in geoschem/geos-chem #1350.
The text $YYYY$MM$DD has to be replaced by \$YYYY\$MM\$DD, as the
"\" is needed to print a literal "$" character.

The definition of RUNDIR_VOLC_TABLE now matches that in the script
run/GCClassic/createRunDir.sh.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca
Copy link
Contributor

This is now fixed in commit 5458939. It will go into GEOS-Chem 14.0.1 (along with other bug fixes), to be released immediately after 14.0.0. I'll close this out now. Thanks for the heads-up @kilicomu!

@lizziel
Copy link
Contributor

lizziel commented Aug 30, 2022

If this does not impact the benchmarks can we include it in 14.0.0? It can go into branch feature/minor_rundir_improvements which we haven't merged in yet.

If this bug fix does impact the benchmarks we'll need to hold off until 14.1.0 to include it.

@lizziel
Copy link
Contributor

lizziel commented Aug 30, 2022

Looking closer at this I see this is a fix for standard simulation not benchmark. I think we should include it in 14.0.0.

@yantosca Octobox
Copy link
Contributor

@lizziel, @Jourdan-He: can I leave it to one of you to implement this?

@lizziel
Copy link
Contributor

lizziel commented Aug 31, 2022

I can bring this into 14.0.0 today.

@lizziel lizziel self-assigned this Aug 31, 2022
@lizziel lizziel modified the milestones: 14.0.1, 14.0.0 Aug 31, 2022
lizziel pushed a commit that referenced this issue Aug 31, 2022
@yantosca @lizziel
Fix typo in RUNDIR_VOLC_TABLE variable in run/GCHP/createRunDir.sh
f7592b4 
This commit fixes the issue raised in geoschem/geos-chem #1350.
The text $YYYY$MM$DD has to be replaced by \$YYYY\$MM\$DD, as the
"\" is needed to print a literal "$" character.

The definition of RUNDIR_VOLC_TABLE now matches that in the script
run/GCClassic/createRunDir.sh.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lizziel lizziel

Labels
category: Bug Something isn't working topic: Configuration Files Related to GEOS-Chem configuration files topic: GCHP Related to GCHP only
Projects
None yet
Milestone
14.0.0
Development

No branches or pull requests
3 participants
@lizziel @yantosca @kilicomu