[PULL REQUEST] Bug fixes: (1) Now check GCClassic History subset regions properly; (2) Use proper restart file paths for dry-run data download (Closes #1039, Closes #1045) #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have now restored the correct paths for GEOS-Chem restart files in download_data.yml. This may have been clobbered by a Git merge. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Interfaces/GCClassic/main.F90: - Pass State_Grid to routine History_Init History/history_mod.F90: - History_Init now accepts the State_Grid object and passes it to routine History_ReadCollectionData - History_ReadCollectionData accepts the State_Grid object. - State_Grid%NX and State_Grid%NY are used to error-check the values of CollectionSubsetInd(:,C) for each collection C. For lon we ensure that indices are within 1 < index < State_Grid%NX, and for lat we ensure that indices are within 1 < index < State_Grid%NY. NOTE: These updates only affect GEOS-Chem Classic History diagnostics. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
category: Bug
This was
linked to
issues
Dec 6, 2021
Closed
laestrada
approved these changes
Dec 6, 2021
|
GCHP integration tests all passed ==============================================================================
GCHP: Execution Test Results
Number of execution tests: 3
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gchp_fullchem_benchmark_merra2_c48...............Execute Simulation.....PASS
gchp_fullchem_standard_merra2_c24................Execute Simulation.....PASS
gchp_TransportTracers_geosfp_c24.................Execute Simulation.....PASS
Summary of execution test results:
------------------------------------------------------------------------------
Execution tests passed: 3
Execution tests failed: 0
Execution tests not completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the corresponding PR for issues #1039 and #1045, which includes fixes for minor user-identified issues. We plan to release these as patch version 13.3.4.